lkml.org 
[lkml]   [2021]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v10 2/8] drivers: thermal: tsens: Don't hardcode sensor slope
    Date


    On 2/17/21 2:40 PM, Ansuel Smith wrote:
    > Function compute_intercept_slope hardcode the sensor slope to
    > SLOPE_DEFAULT. Change this and use the default value only if a slope is
    > not defined. This is needed for tsens VER_0 that has a hardcoded slope
    > table.
    >
    > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

    Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

    Warm Regards
    Thara

    > ---
    > drivers/thermal/qcom/tsens.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
    > index f9126909892b..842f518fdf84 100644
    > --- a/drivers/thermal/qcom/tsens.c
    > +++ b/drivers/thermal/qcom/tsens.c
    > @@ -86,7 +86,8 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
    > "%s: sensor%d - data_point1:%#x data_point2:%#x\n",
    > __func__, i, p1[i], p2[i]);
    >
    > - priv->sensor[i].slope = SLOPE_DEFAULT;
    > + if (!priv->sensor[i].slope)
    > + priv->sensor[i].slope = SLOPE_DEFAULT;
    > if (mode == TWO_PT_CALIB) {
    > /*
    > * slope (m) = adc_code2 - adc_code1 (y2 - y1)/
    >

    --
    Warm Regards
    Thara

    \
     
     \ /
      Last update: 2021-03-18 22:16    [W:3.374 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site