lkml.org 
[lkml]   [2021]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] leds: lgm: Improve Kconfig help
Hi!


> > > help
> > > - Parallel to serial conversion, which is also called SSO
> > > controller,
> > > - can drive external shift register for LED outputs.
> > > - This enables LED support for Serial Shift Output controller(SSO).
> > > + This option enables support for LEDs connected to GPIO lines on
> > > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
> > > + Shift Output(SSO) controller. The driver supports hardware
> >
> > What is Lightning Mountain? The codename is not widely known. Where
> > can we find that hardware? Notebooks? Phones? Only some development
> > boards?
> >
>
> Lightning Mountain is generically a network processor with a primary
> targeted application as Gateway SoC. It has already been added as a
> valid Intel Atom processor variant in
> arch/x86/include/asm/intel-family.h as below:

Yep, but Kconfig users are not going to read header files.

If the SoC is not shipping in any products, state so.

> > > *
> > > - * Copyright (c) 2020 Intel Corporation.
> > > + * Copyright (c) 2021 MaxLinear, Inc.
> > > */
> > >
> >
> > I don't think you can do that, and I don't think you should be doing
> > it in the same patch.
>
> Well noted. Will revert it back now and update later in a separate
> patch. Thanks.

Don't. You can't update copyright like that.

Pavel
--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-03-18 21:38    [W:0.096 / U:1.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site