lkml.org 
[lkml]   [2021]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*
    On Wed, Mar 17, 2021 at 11:12 PM David Laight <David.Laight@aculab.com> wrote:
    >
    ...
    >
    > Isn't MSG_CMSG_COMPAT an internal value?
    > Could it be changed to 1u << 30 instead of 1u << 31 ?
    > Then it wouldn't matter if the high bit of flags got replicated.
    >

    Yeah, MSG_CMSG_COMPAT is an internal value, and maybe
    it's why it is defined as 1<< 31, to make it look different.

    I think it's a good idea to change it to other value which is
    not used, such as 1u<<21.

    I will test it and resend this patch later, thanks~

    With Regards,
    Menglong Dong

    \
     
     \ /
      Last update: 2021-03-18 02:50    [W:5.699 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site