Messages in this thread | | | From | Rob Herring <> | Date | Tue, 16 Mar 2021 11:50:58 -0600 | Subject | Re: [PATCH 04/38] dt-bindings: power: supply: bq25890: Convert to DT schema format |
| |
On Tue, Mar 16, 2021 at 10:46 AM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > > Hi, > > On Mon, Mar 15, 2021 at 12:21:34PM -0600, Rob Herring wrote: > > On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel > > <sebastian.reichel@collabora.com> wrote: > > > + ti,ibatcomp-clamp-microvolt: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: max. charging voltage adjustment due to expected voltage drop on in-series resistor > > > > You don't need a type $ref on properties with a standard unit suffix. > > Though it looks like there's some non-standard ones (-microvolts) in > > the series. > > Ok. Unfortunately most properties in this series use non-standard > ones :(. Newer bindings using common properties have already been > written in YAML and/or make use of simple-battery. > > Can we have a warning for this in the dt_binding_check? Maybe > something like
Yeah, I'm working on that.
> superfluous $ref for property with standard suffix
And having more helpful error messages is on my todo, but not much BW to work on ATM.
Rob
| |