lkml.org 
[lkml]   [2021]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: [PATCH 2/2] kbuild: Enable DT undocumented compatible checks
On Tue, Mar 16, 2021 at 7:55 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Fri, Mar 12, 2021 at 12:38 AM Rob Herring <robh@kernel.org> wrote:
> > dt-validate has an option to warn on any compatible strings which don't
> > match any schema. The option has recently been improved to fix false
> > positives, so let's enable the option. This is useful for tracking
> > compatibles which are undocumented or not yet converted to DT schema.
> > Previously, the only check of undocumented compatible strings has been
> > an imperfect checkpatch.pl check.
> >
> > The option is enabled by default for 'dtbs_check'. This will add more
> > warnings, but some platforms are down to only a handful of these
> > warnings (good job!).
> >
> > There's about 100 cases in the binding examples, so the option is
> > disabled until these are fixed. In the meantime, they can be checked
> > with:
> >
> > make DT_CHECKER_FLAGS=-m dt_binding_check
> >
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Michal Marek <michal.lkml@markovi.net>
> > Cc: linux-kbuild@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Thanks for your patch!
>
> This causes lots of warning when using DT_SCHEMA_FILES, as all
> compatible values in bindings not specified with DT_SCHEMA_FILES
> become unknown.
>
> Perhaps this should be disabled automatically when DT_SCHEMA_FILES
> is specified?

Indeed. I'll fix it up like this:

index 90b095c60f79..ad6938468c11 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -360,7 +360,7 @@ $(overlay-y): FORCE
$(call multi_depend, $(overlay-y), .dtb, -dtbs)

DT_CHECKER ?= dt-validate
-DT_CHECKER_FLAGS ?= -m
+DT_CHECKER_FLAGS ?= $(if $(DT_SCHEMA_FILES),,-m)
DT_BINDING_DIR := Documentation/devicetree/bindings
# DT_TMP_SCHEMA may be overridden from
Documentation/devicetree/bindings/Makefile
DT_TMP_SCHEMA ?= $(objtree)/$(DT_BINDING_DIR)/processed-schema.json
Rob

\
 
 \ /
  Last update: 2021-03-16 15:29    [W:0.045 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site