Messages in this thread | | | Date | Tue, 16 Mar 2021 13:33:01 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C |
| |
On Tue, Mar 16, 2021 at 01:30:36PM +0200, Andy Shevchenko wrote: > On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote: > > From: Johannes Hahn <johannes-hahn@siemens.com> > > > > This allows the RX6110 driver to be automatically assigned to the right > > device on the I2C bus. > > Thanks for all effort! > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> > after addressing the below comments. > > > Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com> > > Signed-off-by: Claudius Heine <ch@denx.de> > > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > I think this is somehow confusing. Either you need to add Co-developed-by of > the corresponding people, or remove SoB (because of From line), i.o.w seems > like Co-dB tag is needed for Johannes or you and something should be done with > Henning's SoB.
Since Johannes' name is in the From, then it seems okay for you (either you a co-developer, than a Co-dB tag, or a submitter, than it's okay to have no Co-dB tag).
-- With Best Regards, Andy Shevchenko
| |