Messages in this thread | | | From | Jonathan Corbet <> | Subject | Re: [PATCH] docs: don't include Documentation/Kconfig twice | Date | Mon, 15 Mar 2021 13:58:49 -0600 |
| |
Sergei Trofimovich <slyfox@gentoo.org> writes:
> Before the change there were two inclusions of Documentation/Kconfig: > lib/Kconfig.debug:source "Documentation/Kconfig" > Kconfig: source "Documentation/Kconfig" > > Kconfig also included 'source "lib/Kconfig.debug"'. > > Noticed as two 'make menuconfig' entries in both top level menu > and in 'Kernel hacking' menu. The patch keeps entries only in > 'Kernel hacking'. > > CC: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > CC: Jonathan Corbet <corbet@lwn.net> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > --- > Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Kconfig b/Kconfig > index 745bc773f567..97ed6389c921 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -28,5 +28,3 @@ source "crypto/Kconfig" > source "lib/Kconfig" > > source "lib/Kconfig.debug" > - > -source "Documentation/Kconfig" > -- > 2.30.1
I agree with not including it twice. Under "kernel hacking" seems like the wrong place to keep it, though. There's a lot more than kernel hacking in the kernel docs, I don't think we should bury it in quite that way. So I'd delete the other one.
Thanks,
jon
| |