Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 15 Mar 2021 10:27:14 -0700 | Subject | Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices |
| |
Hi,
On Fri, Mar 12, 2021 at 3:42 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > The reserved-memory regions used for carrying firmware to be run on the > various cores and co-processors in a Qualcomm platform differs in size, > placement and presence based on each device's feature set and security > configuration. > > Rather than providing some basic set that works on the MTP and then > piecemeal patch this up on the various devices, push the configuration > of these regions out to the individual device dts files. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Changes since v1: > - Added lost memory-region to the db845c wlan node, as spotted by Doug. > > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 90 +++++++++++++------ > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 87 ++++++++++++++++++ > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 87 ++++++++++++++++++ > .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 78 +++++++++++++++- > .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 45 ++++++---- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 83 ----------------- > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 86 ++++++++++++++++++ > 7 files changed, 431 insertions(+), 125 deletions(-)
I will leave it up to you to evaluate Konrad's feedback that this will cause a bunch of duplication since I don't have enough experience w/ Android phones to have an informed opinion. In case it matters, this addresses the feedback I had on v1 and thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I'll also repeat the feedback that I had on v1 that I focused much more on cheza than on other boards and didn't check every last thing on every board to make sure no changes happened.
| |