lkml.org 
[lkml]   [2021]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init
Hi Andy,
Complete newbie here, could you please remind me of the tag you are
referring to?
I am not really familiar with the process.
Thanks,
- Tong


On Fri, Mar 12, 2021 at 10:35 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, Mar 12, 2021 at 4:21 PM Tong Zhang <ztong0001@gmail.com> wrote:
> >
> > ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown()
> > before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the
> > vf2pf_lock is initialized in adf_dev_init(), which can fail and when it
> > fail, the vf2pf_lock is either not initialized or destroyed, a subsequent
> > use of vf2pf_lock will cause issue.
> > To fix this issue, only set this flag if adf_dev_init() returns 0.
> >
> > [ 7.178404] BUG: KASAN: user-memory-access in __mutex_lock.isra.0+0x1ac/0x7c0
> > [ 7.180345] Call Trace:
> > [ 7.182576] mutex_lock+0xc9/0xd0
> > [ 7.183257] adf_iov_putmsg+0x118/0x1a0 [intel_qat]
> > [ 7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat]
> > [ 7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat]
> > [ 7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf]
>
> Don't you miss the tag I gave?
>
> --
> With Best Regards,
> Andy Shevchenko

\
 
 \ /
  Last update: 2021-03-12 16:50    [W:0.376 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site