Messages in this thread | | | Subject | Re: [RFC 0/2] virtio-pmem: Asynchronous flush | From | David Hildenbrand <> | Date | Fri, 12 Mar 2021 09:53:09 +0100 |
| |
On 12.03.21 07:02, Dan Williams wrote: > On Thu, Mar 11, 2021 at 8:21 PM Pankaj Gupta > <pankaj.gupta@cloud.ionos.com> wrote: >> >> Hi David, >> >>>> Jeff reported preflush order issue with the existing implementation >>>> of virtio pmem preflush. Dan suggested[1] to implement asynchronous flush >>>> for virtio pmem using work queue as done in md/RAID. This patch series >>>> intends to solve the preflush ordering issue and also makes the flush >>>> asynchronous from the submitting thread POV. >>>> >>>> Submitting this patch series for feeback and is in WIP. I have >>>> done basic testing and currently doing more testing. >>>> >>>> Pankaj Gupta (2): >>>> pmem: make nvdimm_flush asynchronous >>>> virtio_pmem: Async virtio-pmem flush >>>> >>>> drivers/nvdimm/nd_virtio.c | 66 ++++++++++++++++++++++++++---------- >>>> drivers/nvdimm/pmem.c | 15 ++++---- >>>> drivers/nvdimm/region_devs.c | 3 +- >>>> drivers/nvdimm/virtio_pmem.c | 9 +++++ >>>> drivers/nvdimm/virtio_pmem.h | 12 +++++++ >>>> 5 files changed, 78 insertions(+), 27 deletions(-) >>>> >>>> [1] https://marc.info/?l=linux-kernel&m=157446316409937&w=2 >>>> >>> >>> Just wondering, was there any follow up of this or are we still waiting >>> for feedback? :) >> >> Thank you for bringing this up. >> >> My apologies I could not followup on this. I have another version in my local >> tree but could not post it as I was not sure if I solved the problem >> correctly. I will >> clean it up and post for feedback as soon as I can. >> >> P.S: Due to serious personal/family health issues I am not able to >> devote much time >> on this with other professional commitments. I feel bad that I have >> this unfinished task. >> Just in last one year things have not been stable for me & my family >> and still not getting :( > > No worries Pankaj. Take care of yourself and your family. The > community can handle this for you. I'm open to coaching somebody > through what's involved to get this fix landed.
Absolutely, no need to worry for now - take care of yourself and your loved ones! I was merely stumbling over this series while cleaning up my inbox, wondering if this is still stuck waiting for review/feedback. No need to rush anything or be stressed.
In case I have time to look into this in the future, I'd coordinate in this thread (especially, asking for feedback again so I know where this series stands)!
-- Thanks,
David / dhildenb
| |