lkml.org 
[lkml]   [2021]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks
From
This change adds chip callbacks for the following operations:
1. Notifying port role
2. Notifying orientation

Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
---
Changes since V1:
- Dropped changes related to get_/set_current_limit and pd_capable
callback. Will send them in as separate patches.
---
drivers/usb/typec/tcpm/tcpci.c | 12 +++++++++++-
drivers/usb/typec/tcpm/tcpci.h | 10 ++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
index 027afd7dfdce..c37bbb2e9961 100644
--- a/drivers/usb/typec/tcpm/tcpci.c
+++ b/drivers/usb/typec/tcpm/tcpci.c
@@ -265,9 +265,16 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc,
if (ret < 0)
return ret;

- return regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
+ ret = regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
(polarity == TYPEC_POLARITY_CC2) ?
TCPC_TCPC_CTRL_ORIENTATION : 0);
+ if (ret < 0)
+ return ret;
+
+ if (tcpci->data->set_cc_polarity)
+ tcpci->data->set_cc_polarity(tcpci, tcpci->data, polarity);
+
+ return ret;
}

static void tcpci_set_partner_usb_comm_capable(struct tcpc_dev *tcpc, bool capable)
@@ -395,6 +402,9 @@ static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached,
if (ret < 0)
return ret;

+ if (tcpci->data->set_roles)
+ tcpci->data->set_roles(tcpci, tcpci->data, attached, role, data);
+
return 0;
}

diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h
index 57b6e24e0a0c..75a2c9b575b5 100644
--- a/drivers/usb/typec/tcpm/tcpci.h
+++ b/drivers/usb/typec/tcpm/tcpci.h
@@ -165,6 +165,12 @@ struct tcpci;
* Optional; The USB Communications Capable bit indicates if port
* partner is capable of communication over the USB data lines
* (e.g. D+/- or SS Tx/Rx). Called to notify the status of the bit.
+ * @set_roles:
+ * Optional; This callback notifies the TCPC driver of the resolved
+ * port role and attached status.
+ * @set_cc_polarity:
+ * Optional; This callback notifies the TCPC driver of the resolved
+ * polarity.
*/
struct tcpci_data {
struct regmap *regmap;
@@ -181,6 +187,10 @@ struct tcpci_data {
void (*frs_sourcing_vbus)(struct tcpci *tcpci, struct tcpci_data *data);
void (*set_partner_usb_comm_capable)(struct tcpci *tcpci, struct tcpci_data *data,
bool capable);
+ void (*set_roles)(struct tcpci *tcpci, struct tcpci_data *data, bool attached,
+ enum typec_role role, enum typec_data_role data_role);
+ void (*set_cc_polarity)(struct tcpci *tcpci, struct tcpci_data *data,
+ enum typec_cc_polarity polarity);
};

struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data);
--
2.31.0.rc2.261.g7f71774620-goog
\
 
 \ /
  Last update: 2021-03-12 06:27    [W:0.078 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site