Messages in this thread | | | From | James Morse <> | Subject | Re: [PATCH 04/24] x86/resctrl: Add a separate schema list for resctrl | Date | Fri, 12 Mar 2021 17:10:26 +0000 |
| |
Hi Reinette
On 17/11/2020 21:29, Reinette Chatre wrote: > On 10/30/2020 9:11 AM, James Morse wrote: >> To support multiple architectures, the resctrl code needs to be split >> into a 'fs' specific part in core code, and an arch-specific backend. >> >> It should be difficult for the arch-specific backends to diverge, >> supporting slightly different ABIs for user-space. For example, >> generating, parsing and validating the schema configuration values >> should be done in what becomes the core code to prevent divergence. >> Today, the schema emerge from which entries in the rdt_resources_all >> array the arch code has chosen to enable.
>> Start by creating a struct resctrl_schema, which will eventually hold >> the name and pending configuration values for resctrl. > > Looking ahead I am not able to identify the "pending configuration values" that will > eventually be held in resctrl_schema. With entire series applied there is the name, type, > num_closid, and pointer to the resource.
Looks like a vestige from an earlier version: This referred to the staged configuration in a much earlier version, but this has to stay in the domain structure as its per-domain.
This should refer to the type that is used as an index into the domain's staged configuration array.
Thanks,
James
| |