lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64
From
Date
On 10/03/2021 15:45, Tom Rix wrote:
>
> On 3/10/21 1:45 AM, Lee Jones wrote:
>> On Wed, 10 Mar 2021, Krzysztof Kozlowski wrote:
>>
>>> Prepare for merging Stratix 10, Agilex and N5X into one arm64
>>> architecture by first renaming the ARCH_STRATIX10 into ARCH_SOCFPGA64.
>>>
>>> The existing ARCH_SOCFPGA (in ARMv7) Kconfig symbol cannot be used
>>> because altera_edac driver builds differently between them (with
>>> ifdefs).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>> arch/arm64/Kconfig.platforms | 7 ++++---
>>> arch/arm64/boot/dts/altera/Makefile | 2 +-
>>> arch/arm64/configs/defconfig | 2 +-
>>> drivers/clk/Makefile | 2 +-
>>> drivers/clk/socfpga/Kconfig | 4 ++--
>>> drivers/edac/Kconfig | 2 +-
>>> drivers/edac/altera_edac.c | 10 +++++-----
>>> drivers/firmware/Kconfig | 2 +-
>>> drivers/fpga/Kconfig | 2 +-
>>> drivers/mfd/Kconfig | 2 +-
>> If it's okay with everyone else, it'll be okay with me:
>>
>> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> I think the name is too broad, from the description in the config
>
> + bool "Intel's SoCFPGA ARMv8 Families"
>
> A better name would be ARCH_INTEL_SOCFPGA64
>
> So other vendors like Xilinx could do their own thing.

Many other architectures do not have vendor prefix (TEGRA, EXYNOS,
ZYNQMP etc). I would call it the same as in ARMv7 - ARCH_SOCFPGA - but
the Altera EDAC driver depends on these symbols to be different.
Anyway, I don't mind using something else for the name.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-03-10 16:06    [W:0.056 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site