lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] pinctrl: Ingenic: Fix bug and reformat the code.
From
Date
Hi Paul,

On 2021/3/10 下午10:19, Paul Cercueil wrote:
>
>
> Le mer. 10 mars 2021 à 16:03, Andy Shevchenko
> <andy.shevchenko@gmail.com> a écrit :
>> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
>> <zhouyanjie@wanyeetech.com> wrote:
>>>
>>>  1.Add tabs before values to align the code in the macro definition
>>> section.
>>>  2.Fix bugs related to the MAC of JZ4770, add missing pins to the
>>> MII group.
>>>  3.Adjust the sequence of X1830's SSI related codes to make it
>>> consistent
>>>    with other Ingenic SoCs.
>>>  4.Fix bug in "ingenic_pinconf_get()", so that it can read the
>>> configuration
>>>    of X1830 SoC correctly.
>>>
>>
>> Split to 4 patches then.
>> It's quite hard for everybody to handle regression fixes like this.
>
> Agreed. And the fixes should have a Fixes: tag.
>

Sure.


> -Paul
>

\
 
 \ /
  Last update: 2021-03-10 15:29    [W:0.035 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site