lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call()
    On Wed, Mar 10, 2021 at 08:51:22AM +0100, Jürgen Groß wrote:
    > It is combining the two needed actions: update the static call and
    > set the paravirt_using_native_sched_clock boolean.

    I actually meant what the point of using_native_sched_clock() is but put
    this comment at the wrong place, sorry.

    > Just had another idea: I could add a function to static_call.h for
    > querying the current function. This would avoid the double book keeping
    > and could probably be used later when switching other pv_ops calls to
    > static_call, too (e.g. pv_is_native_spin_unlock()).
    >
    > What do you think?

    Yap, that makes sense. Alternatively, you could even add a bitfield to
    pv_ops which carries that info and since pv_ops is global...

    But yeah, the less bookkeeping the better.

    Thx.

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2021-03-10 15:15    [W:2.206 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site