lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH] greybus/operation: Drop reference when message has been set
Sorry, i mistakenly divided the patch into two commits. What i have sent
is the latest commit which corrected my grammar in the patch.

I will send the full patch soon.


> -----原始邮件-----
> 发件人: "Greg KH" <gregkh@linuxfoundation.org>
> 发送时间: 2021-03-10 17:32:40 (星期三)
> 收件人: "Lv Yunlong" <lyl2019@mail.ustc.edu.cn>
> 抄送: johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
> 主题: Re: [PATCH] greybus/operation: Drop reference when message has been set
>
> On Wed, Mar 10, 2021 at 01:10:14AM -0800, Lv Yunlong wrote:
> > In gb_operation_response_send, get an extra reference
> > before gb_message_send() with this comment "/* Reference will
> > be dropped when message has been sent. */". Therefore, we
> > should drop the got reference not only in the error branch,
> > but also in the complete branch.
>
> That's not what your patch does at all :(
>
\
 
 \ /
  Last update: 2021-03-10 15:09    [W:0.041 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site