lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible
On Wed, Mar 10, 2021 at 11:41:24PM +0100, Rafał Miłecki wrote:
> See inline
>
> On 10.03.2021 22:08, Ansuel Smith wrote:
> > Document nvmem-cells compatible used to treat mtd partitions as a
> > nvmem provider.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > .../bindings/mtd/partitions/nvmem-cells.yaml | 96 +++++++++++++++++++
> > 1 file changed, 96 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > new file mode 100644
> > index 000000000000..f70d7597a6b0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > @@ -0,0 +1,96 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nvmem cells
> > +
> > +description: |
> > + Any partition containing the compatible "nvmem-cells" will register as a
> > + nvmem provider.
> > + Each direct subnodes represents a nvmem cell following the nvmem binding.
> > + Nvmem binding to declare nvmem-cells can be found in:
> > + Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > +
> > +maintainers:
> > + - Ansuel Smith <ansuelsmth@gmail.com>
>
> I think that when Rob wrote:
>
> On 10.03.2021 03:58, Rob Herring wrote:
> > I think this should reference nvmem.yaml.
>
> he meant you using:
>
> allOf:
> - $ref: "nvmem.yaml#"
>
> (you'll need to adjust binding path).
>
> Please check how it's done in Documentation/devicetree/bindings/nvmem/*.yaml files
>
>

Aside from that, should I readd the old properties or I can keep the
compatible as the only one required?

Thanks for the suggestion.

> > +properties:
> > + compatible:
> > + const: nvmem-cells

\
 
 \ /
  Last update: 2021-03-10 23:49    [W:0.045 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site