lkml.org 
[lkml]   [2021]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/5] userfaultfd/selftests: A few cleanups
These look like good cleanups to me! I reviewed all of the patches,
and tried out the resulting selftest program, it seems to work
correctly. So, for what it's worth:

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>


On Tue, Mar 9, 2021 at 4:45 PM Peter Xu <peterx@redhat.com> wrote:
>
> Based on v5.12-rc2-mmots-2021-03-08-21-54.
>
> I wanted to cleanup userfaultfd.c fault handling for a long time. If it's not
> cleaned, when the new code grows the file it'll also grow the size that needs
> to be cleaned... This is my attempt to cleanup the userfaultfd selftest on
> fault handling, to use an err() macro instead of either fprintf() or perror()
> then another exit() call.
>
> The huge cleanup is done in the last patch. The first 4 patches are some other
> standalone cleanups for the same file, so I put them together.
>
> Please review, thanks.
>
> Peter Xu (5):
> userfaultfd/selftests: Use user mode only
> userfaultfd/selftests: Remove the time() check on delayed uffd
> userfaultfd/selftests: Dropping VERIFY check in locking_thread
> userfaultfd/selftests: Only dump counts if mode enabled
> userfaultfd/selftests: Unify error handling
>
> tools/testing/selftests/vm/userfaultfd.c | 742 +++++++----------------
> 1 file changed, 235 insertions(+), 507 deletions(-)
>
> --
> 2.26.2
>
>

\
 
 \ /
  Last update: 2021-03-10 22:29    [W:0.041 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site