lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 018/176] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit e98e2367dfb4b6d7a80c8ce795c644124eff5f36 ]

    The Samsung PMIC datasheets describe the interrupt line as active low
    with a requirement of acknowledge from the CPU. Without specifying the
    interrupt type in Devicetree, kernel might apply some fixed
    configuration, not necessarily working for this hardware.

    Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Link: https://lore.kernel.org/r/20201210212903.216728-7-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
    index 297597442c442..7de6a187ba8f4 100644
    --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
    +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
    @@ -343,7 +343,7 @@
    s2mps13-pmic@66 {
    compatible = "samsung,s2mps13-pmic";
    interrupt-parent = <&gpa0>;
    - interrupts = <7 IRQ_TYPE_NONE>;
    + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
    reg = <0x66>;
    samsung,s2mps11-wrstbi-ground;

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-01 19:31    [W:4.147 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site