lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 129/134] gtp: use icmp_ndo_send helper
    Date
    From: Jason A. Donenfeld <Jason@zx2c4.com>

    commit e0fce6f945a26d4e953a147fe7ca11410322c9fe upstream.

    Because gtp is calling icmp from network device context, it should use
    the ndo helper so that the rate limiting applies correctly.

    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Cc: Harald Welte <laforge@gnumonks.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/gtp.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/gtp.c
    +++ b/drivers/net/gtp.c
    @@ -560,8 +560,8 @@ static int gtp_build_skb_ip4(struct sk_b
    mtu < ntohs(iph->tot_len)) {
    netdev_dbg(dev, "packet too big, fragmentation needed\n");
    memset(IPCB(skb), 0, sizeof(*IPCB(skb)));
    - icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
    - htonl(mtu));
    + icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED,
    + htonl(mtu));
    goto err_rt;
    }


    \
     
     \ /
      Last update: 2021-03-01 19:21    [W:3.766 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site