lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 059/134] IB/umad: Return EIO in case of when device disassociated
    Date
    From: Shay Drory <shayd@nvidia.com>

    [ Upstream commit 4fc5461823c9cad547a9bdfbf17d13f0da0d6bb5 ]

    MAD message received by the user has EINVAL error in all flows
    including when the device is disassociated. That makes it impossible
    for the applications to treat such flow differently.

    Change it to return EIO, so the applications will be able to perform
    disassociation recovery.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Link: https://lore.kernel.org/r/20210125121339.837518-2-leon@kernel.org
    Signed-off-by: Shay Drory <shayd@nvidia.com>
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/user_mad.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c
    index cf93a96b63249..bc6458d760330 100644
    --- a/drivers/infiniband/core/user_mad.c
    +++ b/drivers/infiniband/core/user_mad.c
    @@ -343,6 +343,11 @@ static ssize_t ib_umad_read(struct file *filp, char __user *buf,

    mutex_lock(&file->mutex);

    + if (file->agents_dead) {
    + mutex_unlock(&file->mutex);
    + return -EIO;
    + }
    +
    while (list_empty(&file->recv_list)) {
    mutex_unlock(&file->mutex);

    @@ -485,7 +490,7 @@ static ssize_t ib_umad_write(struct file *filp, const char __user *buf,

    agent = __get_agent(file, packet->mad.hdr.id);
    if (!agent) {
    - ret = -EINVAL;
    + ret = -EIO;
    goto err_up;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-01 18:39    [W:5.434 / U:0.752 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site