lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 022/134] usb: dwc2: Make "trimming xfer length" a debug message
    Date
    From: Guenter Roeck <linux@roeck-us.net>

    [ Upstream commit 1a9e38cabd80356ffb98c2c88fec528ea9644fd5 ]

    With some USB network adapters, such as DM96xx, the following message
    is seen for each maximum size receive packet.

    dwc2 ff540000.usb: dwc2_update_urb_state(): trimming xfer length

    This happens because the packet size requested by the driver is 1522
    bytes, wMaxPacketSize is 64, the dwc2 driver configures the chip to
    receive 24*64 = 1536 bytes, and the chip does indeed send more than
    1522 bytes of data. Since the event does not indicate an error condition,
    the message is just noise. Demote it to debug level.

    Fixes: 7359d482eb4d3 ("staging: HCD files for the DWC2 driver")
    Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
    Reviewed-by: Douglas Anderson <dianders@chromium.org>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
    Link: https://lore.kernel.org/r/20210113112052.17063-4-nsaenzjulienne@suse.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc2/hcd_intr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
    index c80bfd353758b..e39210bd97100 100644
    --- a/drivers/usb/dwc2/hcd_intr.c
    +++ b/drivers/usb/dwc2/hcd_intr.c
    @@ -488,7 +488,7 @@ static int dwc2_update_urb_state(struct dwc2_hsotg *hsotg,
    &short_read);

    if (urb->actual_length + xfer_length > urb->length) {
    - dev_warn(hsotg->dev, "%s(): trimming xfer length\n", __func__);
    + dev_dbg(hsotg->dev, "%s(): trimming xfer length\n", __func__);
    xfer_length = urb->length - urb->actual_length;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-01 18:23    [W:4.520 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site