lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH 12/12] platform/x86/of: add support for PC Engines APU v2/3/4 boards
On Mon, Feb 8, 2021 at 11:22 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:

> + gpio-regs = <
> + AMD_FCH_GPIO_REG_GPIO57 // led1
> + AMD_FCH_GPIO_REG_GPIO58 // led2
> + AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 // led3
> + AMD_FCH_GPIO_REG_GPIO32_GE1 // modesw
> + AMD_FCH_GPIO_REG_GPIO33_GE2 // simawap
> + AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 // mpcie2
> + AMD_FCH_GPIO_REG_GPIO51 // mpcie3
> + >;

Please don't define registers in the DTS files. Determine the set of registers
from the compatible string and put them in the driver. If that is not possible,
the compatible string is not precise enough and needs to indicate properly
which hardware this is.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2021-03-01 15:58    [W:0.274 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site