lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()
On Mon, Mar 01, 2021 at 08:58:55PM +0800, Tian Tao wrote:
> fix the below warnning:
> /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for
> kobj_to_dev()

What creates that warning?

>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/w1/slaves/w1_ds2780.c | 3 ++-
> drivers/w1/slaves/w1_ds2781.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/w1/slaves/w1_ds2780.c b/drivers/w1/slaves/w1_ds2780.c
> index c281fe5..3cde1bb 100644
> --- a/drivers/w1/slaves/w1_ds2780.c
> +++ b/drivers/w1/slaves/w1_ds2780.c
> @@ -90,7 +90,8 @@ static ssize_t w1_slave_read(struct file *filp, struct kobject *kobj,
> struct bin_attribute *bin_attr, char *buf,
> loff_t off, size_t count)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> +

Why the extra line here, but not in the other chunk?

Consistancy is key :)

Please fix up.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-03-01 14:13    [W:0.044 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site