lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese
Date
hjh <huangjianghui@uniontech.com> writes:

> Signed-off-by: hjh <huangjianghui@uniontech.com>
> ---
> Documentation/translations/zh_CN/index.rst | 1 +
> .../zh_CN/sound/hd-audio/controls.rst | 102 ++++++++++++++++++
> .../zh_CN/sound/hd-audio/index.rst | 17 +++
> .../translations/zh_CN/sound/index.rst | 26 +++++
> 4 files changed, 146 insertions(+)
> create mode 100644 Documentation/translations/zh_CN/sound/hd-audio/controls.rst
> create mode 100644 Documentation/translations/zh_CN/sound/hd-audio/index.rst
> create mode 100644 Documentation/translations/zh_CN/sound/index.rst

So you have sent me two versions of this in the last 24 hours with no
indication of what has changed or why I should prefer one over the
other. Always include that information (under the "---" line) when you
send updated versions.

It looks like you got a Reviewed-by tag from Alex on the other version,
but that doesn't appear here; why?

[...]

> diff --git a/Documentation/translations/zh_CN/sound/hd-audio/index.rst b/Documentation/translations/zh_CN/sound/hd-audio/index.rst
> new file mode 100644
> index 000000000000..c287aad51066
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/sound/hd-audio/index.rst
> @@ -0,0 +1,17 @@
> +.. include:: ../../disclaimer-zh_CN.rst
> +
> +:Original: :doc:`../../../../sound/hd-audio/index`
> +:Translator: Huang Jianghui <huangjianghui@uniontech.com>
> +
> +
> +高清音频
> +========
> +
> +.. toctree::
> + :maxdepth: 2
> +
> + notes
> + models
> + controls
> + dp-mst
> + realtek-pc-beep

So you list a bunch of files here, but most of them are not added in
your patch. That will, of course, break the docs build.

> diff --git a/Documentation/translations/zh_CN/sound/index.rst b/Documentation/translations/zh_CN/sound/index.rst
> new file mode 100644
> index 000000000000..42d86b361e42
> --- /dev/null
> +++ b/Documentation/translations/zh_CN/sound/index.rst
> @@ -0,0 +1,26 @@

Similarly, including the index.rst file at this level is good, but...

> +.. include:: ../disclaimer-zh_CN.rst
> +
> +:Original: :doc:`../../../sound/index`
> +:Translator: Huang Jianghui <huangjianghui@uniontech.com>
> +
> +
> +====================
> +Linux 声音子系统文档
> +====================
> +
> +.. toctree::
> + :maxdepth: 2
> +
> + kernel-api/index
> + designs/index
> + soc/index
> + alsa-configuration
> + hd-audio/index
> + cards/index

What are all of these files?

Please fix these issues and make sure that the docs build runs correctly
before resubmitting.

Thanks,

jon

\
 
 \ /
  Last update: 2021-03-02 14:45    [W:0.244 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site