Messages in this thread | | | Date | Mon, 1 Mar 2021 12:32:59 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH] kernel: Return -EFAULT if copy_to_user() fails |
| |
On Mon, Mar 01, 2021 at 07:28:11PM +0800, Wang Qing wrote: > The copy_to_user() function returns the number of bytes remaining to be > copied, but we want to return -EFAULT if the copy doesn't complete. > > Signed-off-by: Wang Qing <wangqing@vivo.com> > ---
Hey Wang,
Thanks for the patch. It looks like override_release() is called in three places and all three places return -EFAULT correctly. They simply treat any as EFAULT. So not sure this change buys us anything.
Christian
| |