lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 665/775] media: i2c: max9286: fix access to unallocated memory
    Date
    From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

    commit e88ccf09e79cf33cac40316ba69c820d9eebc82b upstream.

    The asd allocated with v4l2_async_notifier_add_fwnode_subdev() must be
    of size max9286_asd, otherwise access to max9286_asd->source will go to
    unallocated memory.

    Fixes: 86d37bf31af6 ("media: i2c: max9286: Allocate v4l2_async_subdev dynamically")
    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
    Cc: stable@vger.kernel.org # v5.10+
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Tested-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/i2c/max9286.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/i2c/max9286.c
    +++ b/drivers/media/i2c/max9286.c
    @@ -580,7 +580,7 @@ static int max9286_v4l2_notifier_registe

    asd = v4l2_async_notifier_add_fwnode_subdev(&priv->notifier,
    source->fwnode,
    - sizeof(*asd));
    + sizeof(struct max9286_asd));
    if (IS_ERR(asd)) {
    dev_err(dev, "Failed to add subdev for source %u: %ld",
    i, PTR_ERR(asd));

    \
     
     \ /
      Last update: 2021-03-02 14:40    [W:4.020 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site