lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 698/775] fs/affs: release old buffer head on error path
    Date
    From: Pan Bian <bianpan2016@163.com>

    commit 70779b897395b330ba5a47bed84f94178da599f9 upstream.

    The reference count of the old buffer head should be decremented on path
    that fails to get the new buffer head.

    Fixes: 6b4657667ba0 ("fs/affs: add rename exchange")
    CC: stable@vger.kernel.org # 4.14+
    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/affs/namei.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/affs/namei.c
    +++ b/fs/affs/namei.c
    @@ -460,8 +460,10 @@ affs_xrename(struct inode *old_dir, stru
    return -EIO;

    bh_new = affs_bread(sb, d_inode(new_dentry)->i_ino);
    - if (!bh_new)
    + if (!bh_new) {
    + affs_brelse(bh_old);
    return -EIO;
    + }

    /* Remove old header from its parent directory. */
    affs_lock_dir(old_dir);

    \
     
     \ /
      Last update: 2021-03-02 14:40    [W:4.071 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site