lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 686/775] arm64: uprobe: Return EOPNOTSUPP for AARCH32 instruction probing
    Date
    From: He Zhe <zhe.he@windriver.com>

    commit d47422d953e258ad587b5edf2274eb95d08bdc7d upstream.

    As stated in linux/errno.h, ENOTSUPP should never be seen by user programs.
    When we set up uprobe with 32-bit perf and arm64 kernel, we would see the
    following vague error without useful hint.

    The sys_perf_event_open() syscall returned with 524 (INTERNAL ERROR:
    strerror_r(524, [buf], 128)=22)

    Use EOPNOTSUPP instead to indicate such cases.

    Signed-off-by: He Zhe <zhe.he@windriver.com>
    Link: https://lore.kernel.org/r/20210223082535.48730-1-zhe.he@windriver.com
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Will Deacon <will@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm64/kernel/probes/uprobes.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/arm64/kernel/probes/uprobes.c
    +++ b/arch/arm64/kernel/probes/uprobes.c
    @@ -38,7 +38,7 @@ int arch_uprobe_analyze_insn(struct arch

    /* TODO: Currently we do not support AARCH32 instruction probing */
    if (mm->context.flags & MMCF_AARCH32)
    - return -ENOTSUPP;
    + return -EOPNOTSUPP;
    else if (!IS_ALIGNED(addr, AARCH64_INSN_SIZE))
    return -EINVAL;


    \
     
     \ /
      Last update: 2021-03-02 14:32    [W:3.858 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site