lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 553/775] r8169: fix jumbo packet handling on RTL8168e
    Date
    From: Heiner Kallweit <hkallweit1@gmail.com>

    [ Upstream commit 6cf739131a15e4177e58a1b4f2bede9d5da78552 ]

    Josef reported [0] that using jumbo packets fails on RTL8168e.
    Aligning the values for register MaxTxPacketSize with the
    vendor driver fixes the problem.

    [0] https://bugzilla.kernel.org/show_bug.cgi?id=211827

    Fixes: d58d46b5d851 ("r8169: jumbo fixes.")
    Reported-by: Josef Oškera <joskera@redhat.com>
    Tested-by: Josef Oškera <joskera@redhat.com>
    Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
    Link: https://lore.kernel.org/r/b15ddef7-0d50-4320-18f4-6a3f86fbfd3e@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/realtek/r8169_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
    index 0d78408b4e269..470ff6b3ebef1 100644
    --- a/drivers/net/ethernet/realtek/r8169_main.c
    +++ b/drivers/net/ethernet/realtek/r8169_main.c
    @@ -2315,14 +2315,14 @@ static void r8168dp_hw_jumbo_disable(struct rtl8169_private *tp)

    static void r8168e_hw_jumbo_enable(struct rtl8169_private *tp)
    {
    - RTL_W8(tp, MaxTxPacketSize, 0x3f);
    + RTL_W8(tp, MaxTxPacketSize, 0x24);
    RTL_W8(tp, Config3, RTL_R8(tp, Config3) | Jumbo_En0);
    RTL_W8(tp, Config4, RTL_R8(tp, Config4) | 0x01);
    }

    static void r8168e_hw_jumbo_disable(struct rtl8169_private *tp)
    {
    - RTL_W8(tp, MaxTxPacketSize, 0x0c);
    + RTL_W8(tp, MaxTxPacketSize, 0x3f);
    RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Jumbo_En0);
    RTL_W8(tp, Config4, RTL_R8(tp, Config4) & ~0x01);
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 14:25    [W:2.686 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site