lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 486/775] pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare()
    Date
    From: Simon South <simon@simonsouth.net>

    [ Upstream commit d5d8d675865ccddfe4da26c85f22c55cec663bf2 ]

    If rockchip_pwm_probe() fails to register a PWM device it calls
    clk_unprepare() for the device's PWM clock, without having first disabled
    the clock and before jumping to an error handler that also unprepares
    it. This is likely to produce warnings from the kernel about the clock
    being unprepared when it is still enabled, and then being unprepared when
    it has already been unprepared.

    Prevent these warnings by removing this unnecessary call to
    clk_unprepare().

    Fixes: 48cf973cae33 ("pwm: rockchip: Avoid glitches on already running PWMs")
    Signed-off-by: Simon South <simon@simonsouth.net>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pwm/pwm-rockchip.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
    index e6929bc739684..90f969f9f5e2b 100644
    --- a/drivers/pwm/pwm-rockchip.c
    +++ b/drivers/pwm/pwm-rockchip.c
    @@ -351,7 +351,6 @@ static int rockchip_pwm_probe(struct platform_device *pdev)

    ret = pwmchip_add(&pc->chip);
    if (ret < 0) {
    - clk_unprepare(pc->clk);
    dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
    goto err_pclk;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 05:11    [W:2.452 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site