lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 513/775] drm/msm/dp: Add a missing semi-colon
    Date
    From: Stephen Boyd <swboyd@chromium.org>

    [ Upstream commit 182b4a2d251305201b6f9cae29067f7112f05835 ]

    A missing semicolon here causes my external display to stop working.
    Indeed, missing the semicolon on the return statement leads to
    dp_panel_update_tu_timings() not existing because the compiler thinks
    it's part of the return statement of a void function, so it must not be
    important.

    $ ./scripts/bloat-o-meter before.o after.o
    add/remove: 1/1 grow/shrink: 0/1 up/down: 7400/-7540 (-140)
    Function old new delta
    dp_panel_update_tu_timings - 7400 +7400
    _dp_ctrl_calc_tu.constprop 18024 17900 -124
    dp_panel_update_tu_timings.constprop 7416 - -7416
    Total: Before=54440, After=54300, chg -0.26%

    Add a semicolon so this function works like it used to.

    Cc: Sean Paul <sean@poorly.run>
    Cc: Kuogee Hsieh <khsieh@codeaurora.org>
    Cc: linux-arm-msm@vger.kernel.org
    Cc: dri-devel@lists.freedesktop.org
    Cc: freedreno@lists.freedesktop.org
    Cc: Lee Jones <lee.jones@linaro.org>
    Fixes: cc9014bf63a4 ("drm/msm/dp/dp_ctrl: Move 'tu' from the stack to the heap")
    Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
    index e3462f5d96d75..6cbe10af0a7af 100644
    --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
    +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
    @@ -631,7 +631,7 @@ static void _dp_ctrl_calc_tu(struct dp_tu_calc_input *in,

    tu = kzalloc(sizeof(*tu), GFP_KERNEL);
    if (!tu)
    - return
    + return;

    dp_panel_update_tu_timings(in, tu);

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 05:10    [W:4.083 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site