lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 366/775] regulator: s5m8767: Drop regulators OF node reference
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit a5872bd3398d0ff2ce4c77794bc7837899c69024 ]

    The device node reference obtained with of_get_child_by_name() should be
    dropped on error paths.

    Fixes: 26aec009f6b6 ("regulator: add device tree support for s5m8767")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20210121155914.48034-1-krzk@kernel.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/s5m8767.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
    index 48dd95b3ff45a..7c111bbdc2afa 100644
    --- a/drivers/regulator/s5m8767.c
    +++ b/drivers/regulator/s5m8767.c
    @@ -544,14 +544,18 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev,
    rdata = devm_kcalloc(&pdev->dev,
    pdata->num_regulators, sizeof(*rdata),
    GFP_KERNEL);
    - if (!rdata)
    + if (!rdata) {
    + of_node_put(regulators_np);
    return -ENOMEM;
    + }

    rmode = devm_kcalloc(&pdev->dev,
    pdata->num_regulators, sizeof(*rmode),
    GFP_KERNEL);
    - if (!rmode)
    + if (!rmode) {
    + of_node_put(regulators_np);
    return -ENOMEM;
    + }

    pdata->regulators = rdata;
    pdata->opmode = rmode;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 05:10    [W:2.317 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site