lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 398/775] mmc: usdhi6rol0: Fix a resource leak in the error handling path of the probe
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 6052b3c370fb82dec28bcfff6d7ec0da84ac087a ]

    A call to 'ausdhi6_dma_release()' to undo a previous call to
    'usdhi6_dma_request()' is missing in the error handling path of the probe
    function.

    It is already present in the remove function.

    Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/20201217210922.165340-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/usdhi6rol0.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
    index e2d5112d809dc..615f3d008af1e 100644
    --- a/drivers/mmc/host/usdhi6rol0.c
    +++ b/drivers/mmc/host/usdhi6rol0.c
    @@ -1858,10 +1858,12 @@ static int usdhi6_probe(struct platform_device *pdev)

    ret = mmc_add_host(mmc);
    if (ret < 0)
    - goto e_clk_off;
    + goto e_release_dma;

    return 0;

    +e_release_dma:
    + usdhi6_dma_release(host);
    e_clk_off:
    clk_disable_unprepare(host->clk);
    e_free_mmc:
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 05:10    [W:4.030 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site