lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 296/775] ubifs: Fix memleak in ubifs_init_authentication
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit 11b8ab3836454a2600e396f34731e491b661f9d5 ]

    When crypto_shash_digestsize() fails, c->hmac_tfm
    has not been freed before returning, which leads
    to memleak.

    Fixes: 49525e5eecca5 ("ubifs: Add helper functions for authentication support")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ubifs/auth.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
    index 51a7c8c2c3f0a..e564d5ff87816 100644
    --- a/fs/ubifs/auth.c
    +++ b/fs/ubifs/auth.c
    @@ -327,7 +327,7 @@ int ubifs_init_authentication(struct ubifs_info *c)
    ubifs_err(c, "hmac %s is bigger than maximum allowed hmac size (%d > %d)",
    hmac_name, c->hmac_desc_len, UBIFS_HMAC_ARR_SZ);
    err = -EINVAL;
    - goto out_free_hash;
    + goto out_free_hmac;
    }

    err = crypto_shash_setkey(c->hmac_tfm, ukp->data, ukp->datalen);
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 04:40    [W:4.056 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site