lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 038/775] Bluetooth: hci_qca: Fix memleak in qca_controller_memdump
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit 71f8e707557b9bc25dc90a59a752528d4e7c1cbf ]

    When __le32_to_cpu() fails, qca_memdump should be freed
    just like when vmalloc() fails.

    Fixes: d841502c79e3f ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bluetooth/hci_qca.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
    index 4a963682c7021..5dbcb7c42b805 100644
    --- a/drivers/bluetooth/hci_qca.c
    +++ b/drivers/bluetooth/hci_qca.c
    @@ -1024,7 +1024,9 @@ static void qca_controller_memdump(struct work_struct *work)
    dump_size = __le32_to_cpu(dump->dump_size);
    if (!(dump_size)) {
    bt_dev_err(hu->hdev, "Rx invalid memdump size");
    + kfree(qca_memdump);
    kfree_skb(skb);
    + qca->qca_memdump = NULL;
    mutex_unlock(&qca->hci_memdump_lock);
    return;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 04:10    [W:3.090 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site