lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 164/663] media: camss: missing error code in msm_video_register()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 9c67ed2ab299123872be14a3dc2ea44ce7e4538b ]

    This error path returns success but it should return -EINVAL.

    Fixes: cba3819d1e93 ("media: camss: Format configuration per hardware version")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Robert Foss <robert.foss@linaro.org>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/qcom/camss/camss-video.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c
    index 114c3ae4a4abb..15965e63cb619 100644
    --- a/drivers/media/platform/qcom/camss/camss-video.c
    +++ b/drivers/media/platform/qcom/camss/camss-video.c
    @@ -979,6 +979,7 @@ int msm_video_register(struct camss_video *video, struct v4l2_device *v4l2_dev,
    video->nformats = ARRAY_SIZE(formats_rdi_8x96);
    }
    } else {
    + ret = -EINVAL;
    goto error_video_register;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:41    [W:4.675 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site