lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 361/775] regulator: axp20x: Fix reference cout leak
    Date
    From: Pan Bian <bianpan2016@163.com>

    [ Upstream commit e78bf6be7edaacb39778f3a89416caddfc6c6d70 ]

    Decrements the reference count of device node and its child node.

    Fixes: dfe7a1b058bb ("regulator: AXP20x: Add support for regulators subsystem")
    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Link: https://lore.kernel.org/r/20210120123313.107640-1-bianpan2016@163.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/axp20x-regulator.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
    index 90cb8445f7216..d260c442b788d 100644
    --- a/drivers/regulator/axp20x-regulator.c
    +++ b/drivers/regulator/axp20x-regulator.c
    @@ -1070,7 +1070,7 @@ static int axp20x_set_dcdc_freq(struct platform_device *pdev, u32 dcdcfreq)
    static int axp20x_regulator_parse_dt(struct platform_device *pdev)
    {
    struct device_node *np, *regulators;
    - int ret;
    + int ret = 0;
    u32 dcdcfreq = 0;

    np = of_node_get(pdev->dev.parent->of_node);
    @@ -1085,13 +1085,12 @@ static int axp20x_regulator_parse_dt(struct platform_device *pdev)
    ret = axp20x_set_dcdc_freq(pdev, dcdcfreq);
    if (ret < 0) {
    dev_err(&pdev->dev, "Error setting dcdc frequency: %d\n", ret);
    - return ret;
    }
    -
    of_node_put(regulators);
    }

    - return 0;
    + of_node_put(np);
    + return ret;
    }

    static int axp20x_set_dcdc_workmode(struct regulator_dev *rdev, int id, u32 workmode)
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:41    [W:2.244 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site