lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 210/663] mtd: parsers: afs: Fix freeing the part name memory in failure
    Date
    From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

    [ Upstream commit 7b844cf445f0a7daa68be0ce71eb2c88d68b0c5d ]

    In the case of failure while parsing the partitions, the iterator should
    be pre decremented by one before starting to free the memory allocated
    by kstrdup(). Because in the failure case, kstrdup() will not succeed
    and thus no memory will be allocated for the current iteration.

    Fixes: 1fca1f6abb38 ("mtd: afs: simplify partition parsing")
    Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20210104041137.113075-5-manivannan.sadhasivam@linaro.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/parsers/afs.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/mtd/parsers/afs.c b/drivers/mtd/parsers/afs.c
    index 980e332bdac48..26116694c821b 100644
    --- a/drivers/mtd/parsers/afs.c
    +++ b/drivers/mtd/parsers/afs.c
    @@ -370,10 +370,8 @@ static int parse_afs_partitions(struct mtd_info *mtd,
    return i;

    out_free_parts:
    - while (i >= 0) {
    + while (--i >= 0)
    kfree(parts[i].name);
    - i--;
    - }
    kfree(parts);
    *pparts = NULL;
    return ret;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:40    [W:2.132 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site