lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 450/663] net/mlx4_core: Add missed mlx4_free_cmd_mailbox()
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit 8eb65fda4a6dbd59cd5de24b106a10b6ee0d2176 ]

    mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to
    free the memory region allocated by mlx4_alloc_cmd_mailbox() before
    an exit.
    Add the missed call to fix it.

    Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports")
    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
    Link: https://lore.kernel.org/r/20210221143559.390277-1-hslester96@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
    index 1187ef1375e29..cb341372d5a35 100644
    --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
    +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
    @@ -4986,6 +4986,7 @@ static int mlx4_do_mirror_rule(struct mlx4_dev *dev, struct res_fs_rule *fs_rule

    if (!fs_rule->mirr_mbox) {
    mlx4_err(dev, "rule mirroring mailbox is null\n");
    + mlx4_free_cmd_mailbox(dev, mailbox);
    return -EINVAL;
    }
    memcpy(mailbox->buf, fs_rule->mirr_mbox, fs_rule->mirr_mbox_size);
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:10    [W:4.409 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site