lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 194/775] media: i2c: ov5670: Fix PIXEL_RATE minimum value
    Date
    From: Jacopo Mondi <jacopo@jmondi.org>

    [ Upstream commit dc1eb7c9c290cba52937c9a224b22a400bb0ffd7 ]

    The driver currently reports a single supported value for
    V4L2_CID_PIXEL_RATE and initializes the control's minimum value to 0,
    which is very risky, as userspace might accidentally use it as divider
    when calculating the time duration of a line.

    Fix this by using as minimum the only supported value when registering
    the control.

    Fixes: 5de35c9b8dcd1 ("media: i2c: Add Omnivision OV5670 5M sensor support")
    Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/ov5670.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
    index 148fd4e05029a..866c8c2e8f59a 100644
    --- a/drivers/media/i2c/ov5670.c
    +++ b/drivers/media/i2c/ov5670.c
    @@ -2084,7 +2084,8 @@ static int ov5670_init_controls(struct ov5670 *ov5670)

    /* By default, V4L2_CID_PIXEL_RATE is read only */
    ov5670->pixel_rate = v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops,
    - V4L2_CID_PIXEL_RATE, 0,
    + V4L2_CID_PIXEL_RATE,
    + link_freq_configs[0].pixel_rate,
    link_freq_configs[0].pixel_rate,
    1,
    link_freq_configs[0].pixel_rate);
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 03:10    [W:4.714 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site