lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/7] x86/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
On Mon, Mar 01, 2021 at 09:45:07AM +0100, David Hildenbrand wrote:
> Take your config and set
> X86_5LEVEL=n
> (because it enforces SPARSEMEM_VMEMMAP)
> and
> SPARSEMEM_VMEMMAP=n
>
> When compiling, you'll end up with a config like
> CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y
> # CONFIG_SPARSEMEM_VMEMMAP is not set

I see

>
> Yet, with your patch you would get
>
> ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE=y
>
> And it would not get fenced off in the code, right?
>
>
> I think you either have to check (IS_ENABLED(CONFIG_SPARSEMEM_VMEMMAP)) in
> addition in your code, or enforce it differently. Like
>
>
> config MHP_MEMMAP_ON_MEMORY
> depends on SPARSEMEM_VMEMMAP && ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> bool
>
>
> Then you can simplify the arch Kconfig settings, removing the sparesemem
> dependency there.

Yes, will do it this way.

Thanks!

--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2021-03-01 11:11    [W:0.852 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site