lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 318/663] objtool: Fix error handling for STD/CLD warnings
    Date
    From: Josh Poimboeuf <jpoimboe@redhat.com>

    [ Upstream commit 6f567c9300a5ebd7b18c26dda1c8d6ffbdd0debd ]

    Actually return an error (and display a backtrace, if requested) for
    directional bit warnings.

    Fixes: 2f0f9e9ad7b3 ("objtool: Add Direction Flag validation")
    Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    Link: https://lore.kernel.org/r/dc70f2adbc72f09526f7cab5b6feb8bf7f6c5ad4.1611263461.git.jpoimboe@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/objtool/check.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/tools/objtool/check.c b/tools/objtool/check.c
    index 4bd30315eb62b..2e154f00ccec2 100644
    --- a/tools/objtool/check.c
    +++ b/tools/objtool/check.c
    @@ -2592,15 +2592,19 @@ static int validate_branch(struct objtool_file *file, struct symbol *func,
    break;

    case INSN_STD:
    - if (state.df)
    + if (state.df) {
    WARN_FUNC("recursive STD", sec, insn->offset);
    + return 1;
    + }

    state.df = true;
    break;

    case INSN_CLD:
    - if (!state.df && func)
    + if (!state.df && func) {
    WARN_FUNC("redundant CLD", sec, insn->offset);
    + return 1;
    + }

    state.df = false;
    break;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 02:41    [W:3.812 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site