lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 101/775] bnxt_en: Fix devlink infos stored fw.psid version format.
    Date
    From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

    [ Upstream commit db28b6c77f4050f62599267a886b61fbd6504633 ]

    The running fw.psid version is in decimal format but the stored
    fw.psid is in hex format. This can mislead the user to reset the
    NIC to activate the stored version to become the running version.

    Fix it to display the stored fw.psid in decimal format.

    Fixes: 1388875b3916 ("bnxt_en: Add stored FW version info to devlink info_get cb.")
    Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
    index 6b7b69ed62db0..a9bcf887d2fbe 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
    @@ -472,8 +472,8 @@ static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
    if (BNXT_PF(bp) && !bnxt_hwrm_get_nvm_cfg_ver(bp, &nvm_cfg_ver)) {
    u32 ver = nvm_cfg_ver.vu32;

    - sprintf(buf, "%X.%X.%X", (ver >> 16) & 0xF, (ver >> 8) & 0xF,
    - ver & 0xF);
    + sprintf(buf, "%d.%d.%d", (ver >> 16) & 0xf, (ver >> 8) & 0xf,
    + ver & 0xf);
    rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
    DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
    buf);
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 02:41    [W:2.568 / U:1.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site