lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 391/663] sparc: fix led.c driver when PROC_FS is not enabled
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit b3554aa2470b5db1222c31e08ec9c29ab33eabc7 ]

    Fix Sparc build when CONFIG_PROC_FS is not enabled.

    Fixes this build error:
    arch/sparc/kernel/led.c:107:30: error: 'led_proc_ops' defined but not used [-Werror=unused-const-variable=]
    107 | static const struct proc_ops led_proc_ops = {
    | ^~~~~~~~~~~~
    cc1: all warnings being treated as errors

    Fixes: 97a32539b956 ("proc: convert everything to "struct proc_ops"")
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Cc: Alexey Dobriyan <adobriyan@gmail.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Lars Kotthoff <metalhead@metalhead.ws>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: sparclinux@vger.kernel.org
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/sparc/kernel/led.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/sparc/kernel/led.c b/arch/sparc/kernel/led.c
    index bd48575172c32..3a66e62eb2a0e 100644
    --- a/arch/sparc/kernel/led.c
    +++ b/arch/sparc/kernel/led.c
    @@ -50,6 +50,7 @@ static void led_blink(struct timer_list *unused)
    add_timer(&led_blink_timer);
    }

    +#ifdef CONFIG_PROC_FS
    static int led_proc_show(struct seq_file *m, void *v)
    {
    if (get_auxio() & AUXIO_LED)
    @@ -111,6 +112,7 @@ static const struct proc_ops led_proc_ops = {
    .proc_release = single_release,
    .proc_write = led_proc_write,
    };
    +#endif

    static struct proc_dir_entry *led;

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 02:40    [W:2.455 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site