lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 003/775] debugfs: be more robust at handling improper input in debugfs_lookup()
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    commit bc6de804d36b3709d54fa22bd128cbac91c11526 upstream.

    debugfs_lookup() doesn't like it if it is passed an illegal name
    pointer, or if the filesystem isn't even initialized yet. If either of
    these happen, it will crash the system, so fix it up by properly testing
    for valid input and that we are up and running before trying to find a
    file in the filesystem.

    Cc: "Rafael J. Wysocki" <rafael@kernel.org>
    Cc: stable <stable@vger.kernel.org>
    Reported-by: Michael Walle <michael@walle.cc>
    Tested-by: Michael Walle <michael@walle.cc>
    Tested-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20210218100818.3622317-1-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/debugfs/inode.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/debugfs/inode.c
    +++ b/fs/debugfs/inode.c
    @@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char
    {
    struct dentry *dentry;

    - if (IS_ERR(parent))
    + if (!debugfs_initialized() || IS_ERR_OR_NULL(name) || IS_ERR(parent))
    return NULL;

    if (!parent)

    \
     
     \ /
      Last update: 2021-03-02 01:34    [W:4.224 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site