lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 276/663] dmaengine: fsldma: Fix a resource leak in the remove function
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit cbc0ad004c03ad7971726a5db3ec84dba3dcb857 ]

    A 'irq_dispose_mapping()' call is missing in the remove function.
    Add it.

    This is needed to undo the 'irq_of_parse_and_map() call from the probe
    function and already part of the error handling path of the probe function.

    It was added in the probe function only in commit d3f620b2c4fe ("fsldma:
    simplify IRQ probing and handling")

    Fixes: 77cd62e8082b ("fsldma: allow Freescale Elo DMA driver to be compiled as a module")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/20201212160516.92515-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/fsldma.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
    index 0feb323bae1e3..554f70a0c18c0 100644
    --- a/drivers/dma/fsldma.c
    +++ b/drivers/dma/fsldma.c
    @@ -1314,6 +1314,7 @@ static int fsldma_of_remove(struct platform_device *op)
    if (fdev->chan[i])
    fsl_dma_chan_remove(fdev->chan[i]);
    }
    + irq_dispose_mapping(fdev->irq);

    iounmap(fdev->regs);
    kfree(fdev);
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 01:34    [W:3.028 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site