lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 029/775] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit cb31334687db31c691901269d65074a7ffaecb18 ]

    The Samsung PMIC datasheets describe the interrupt line as active low
    with a requirement of acknowledge from the CPU. Without specifying the
    interrupt type in Devicetree, kernel might apply some fixed
    configuration, not necessarily working for this hardware.

    Fixes: b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for ARTIK5 module")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Link: https://lore.kernel.org/r/20201210212903.216728-1-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
    index 04290ec4583a6..829c05b2c405f 100644
    --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
    +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
    @@ -79,7 +79,7 @@
    pmic@66 {
    compatible = "samsung,s2mps14-pmic";
    interrupt-parent = <&gpx3>;
    - interrupts = <5 IRQ_TYPE_NONE>;
    + interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
    pinctrl-names = "default";
    pinctrl-0 = <&s2mps14_irq>;
    reg = <0x66>;
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 01:24    [W:2.749 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site