lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 098/663] bnxt_en: reverse order of TX disable and carrier off
    Date
    From: Edwin Peer <edwin.peer@broadcom.com>

    [ Upstream commit 132e0b65dc2b8bfa9721bfce834191f24fd1d7ed ]

    A TX queue can potentially immediately timeout after it is stopped
    and the last TX timestamp on that queue was more than 5 seconds ago with
    carrier still up. Prevent these intermittent false TX timeouts
    by bringing down carrier first before calling netif_tx_disable().

    Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
    Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    index 033bfab24ef2f..c7c5c01a783a0 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -8856,9 +8856,10 @@ void bnxt_tx_disable(struct bnxt *bp)
    txr->dev_state = BNXT_DEV_STATE_CLOSING;
    }
    }
    + /* Drop carrier first to prevent TX timeout */
    + netif_carrier_off(bp->dev);
    /* Stop all TX queues */
    netif_tx_disable(bp->dev);
    - netif_carrier_off(bp->dev);
    }

    void bnxt_tx_enable(struct bnxt *bp)
    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 01:14    [W:2.346 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site