lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.11 113/775] net/mlx5: Disallow RoCE on lag device
    Date
    From: Shay Drory <shayd@nvidia.com>

    [ Upstream commit 7ab91f2b03367f9d25dd807ebdfb0d67295e0e41 ]

    In lag mode, setting roce enabled/disable of lag device have no effect.
    e.g.: bond device (roce/vf_lag) roce status remain unchanged.
    Therefore disable it and add an error message.

    Fixes: cc9defcbb8fa ("net/mlx5: Handle "enable_roce" devlink param")
    Signed-off-by: Shay Drory <shayd@nvidia.com>
    Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
    index 317ce6b80b23b..c7073193db140 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
    @@ -273,8 +273,8 @@ static int mlx5_devlink_enable_roce_validate(struct devlink *devlink, u32 id,
    NL_SET_ERR_MSG_MOD(extack, "Device doesn't support RoCE");
    return -EOPNOTSUPP;
    }
    - if (mlx5_core_is_mp_slave(dev)) {
    - NL_SET_ERR_MSG_MOD(extack, "Multi port slave device can't configure RoCE");
    + if (mlx5_core_is_mp_slave(dev) || mlx5_lag_is_active(dev)) {
    + NL_SET_ERR_MSG_MOD(extack, "Multi port slave/Lag device can't configure RoCE");
    return -EOPNOTSUPP;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2021-03-02 01:14    [W:4.074 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site